-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37994 - Populate bootc fields from facts and associate hosts with manifest entities #11209
Fixes #37994 - Populate bootc fields from facts and associate hosts with manifest entities #11209
Conversation
366b67e
to
6ef684c
Compare
<Flex direction={{ default: 'column' }}> | ||
<DescriptionList isHorizontal> | ||
<DescriptionListGroup> | ||
<Dt>{__('Booted image')}</Dt> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to be consistent with Insights which calls it Running image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I can do that.
Should I also add the other info we collect? I can also show available, staged, and rollback so it's just like insights.
cc @ianballou
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could also add any of those as options for additional columns you can add. Maybe just "Running image" would make sense. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these image information will be displayed in the image information card on details tab for each bootc hosts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize that the hover over text was different from the window that pops up when you click on the icon. I suppose the blurb could go in the hover over part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't add a blurb in the popover. The one in the screenshot is too downstream-oriented and I'm not sure what it would say for upstream. For now it just has the running image and digest; see what you think..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the small comments, this is working really great!
Updated image mode icons and scoped search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, let's ship it.
Some tests failed but the errors were unrelated. Re-kicked them. |
What are the changes introduced in this pull request?
Considerations taken when implementing this change?
I didn't use the correct image mode / package mode icons in the table column. This is because it would require Font Awesome icons which we don't have set up.For now I'm using the BundleIcon for package mode, and the MiddlewareIcon for image mode.What are the testing steps for this pull request?
Setup
/etc/rhsm/facts/bootc.facts
subscription-manager facts --update
Testing